Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only]Adjust expected failures file #2117

Merged
merged 1 commit into from
Jun 9, 2021
Merged

[Tests-Only]Adjust expected failures file #2117

merged 1 commit into from
Jun 9, 2021

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Jun 3, 2021

Description

This PR adjusts the issues in the expected failures file. Also, some of the tests are needed to be skipped on ocis as they are not to be implemented in ocis immediately. So, this PR also adjusts the notToImplementOnOCIS tags for such scenarios.

Related Issue

Motivation and Context

Some of the expected-to-fail scenarios in the expected-failures file were tagged with the issues which are already closed. So this PR adjusts the issues tagged for the expected failures file.

How Has This Been Tested:

  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@jasson99 jasson99 mentioned this pull request Jun 3, 2021
Merged
11 tasks
@jasson99 jasson99 self-assigned this Jun 3, 2021
@jasson99 jasson99 force-pushed the adjustIssuesInExpectedFailures branch from b0f040f to ceaa84a Compare June 3, 2021 11:29
@jasson99 jasson99 marked this pull request as ready for review June 4, 2021 06:44
@jasson99 jasson99 force-pushed the adjustIssuesInExpectedFailures branch 6 times, most recently from dbc100d to a5e0e88 Compare June 8, 2021 08:58
@jasson99 jasson99 force-pushed the adjustIssuesInExpectedFailures branch from a5e0e88 to c170e27 Compare June 8, 2021 11:23
@jasson99 jasson99 changed the title [Tests-Only][Do-Not_Merge]Adjust expected failures file [Tests-Only]Adjust expected failures file Jun 8, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

dpakach
dpakach reviewed Jun 9, 2021
View reviewed changes
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍🏼

@phil-davis phil-davis merged commit 8251e62 into master Jun 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the adjustIssuesInExpectedFailures branch June 9, 2021 03:33
ownclouders pushed a commit that referenced this pull request Jun 9, 2021
@phil-davis
commit 8251e62
0527eaf 
Merge: 820205d c170e27
Author: Phil Davis <phil@jankaritech.com>
Date:   Wed Jun 9 09:18:47 2021 +0545

    Merge pull request #2117 from owncloud/adjustIssuesInExpectedFailures

    [Tests-Only]Adjust expected failures file
@phil-davis phil-davis mentioned this pull request Jun 9, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpakach dpakach dpakach left review comments

@phil-davis phil-davis phil-davis approved these changes

Assignees

@jasson99 jasson99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jasson99 @phil-davis @dpakach