Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only]Adjust expected failures file #1778

Merged

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Jun 9, 2021

Description

This PR adjusts the issues in the expected failures file. The public link tests using the old webdav API are now skipped in ocis, with tag notToImplementOnOcis , therefore, the skipped tests are to be removed/adjusted in the expected failures file. Also, some of the tests were still tagged with the issues which are already closed. So, such scenarios are tagged with proper issues.

Related Issue

Motivation and Context

Some of the expected-to-fail scenarios in the expected-failures file were tagged with the issues which are already closed. So this PR adjusts the issues tagged for the expected failures file.

How Has This Been Tested:

  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@jasson99 jasson99 requested a review from labkode as a code owner June 9, 2021 05:19
@phil-davis phil-davis self-requested a review June 9, 2021 06:08
@phil-davis
Copy link
Contributor

Needs changes to expected-failures on S3NG storage: https://drone.cernbox.cern.ch/cs3org/reva/1718/24/7
And couple of adjustments for exxpected failure on ownCloud storage: https://drone.cernbox.cern.ch/cs3org/reva/1718/15/7

@jasson99 jasson99 force-pushed the adjustIssuesInExpectedFailures branch from 1b63c19 to 5b1e189 Compare June 9, 2021 06:24
@phil-davis phil-davis requested a review from ishank011 June 9, 2021 07:24
@phil-davis
Copy link
Contributor

Note: similar PR in OCIS is owncloud/ocis#2117

@ishank011 ishank011 merged commit 5eb8a22 into cs3org:master Jun 9, 2021
@phil-davis phil-davis deleted the adjustIssuesInExpectedFailures branch June 9, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants