Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update port ranges add debug config #3827

Merged
merged 4 commits into from
May 18, 2022
Merged

update port ranges add debug config #3827

merged 4 commits into from
May 18, 2022

Conversation

wkloucek
Copy link
Contributor

Description

updates port ranges and ensures the debug server has default port

cc @mmattel

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek requested review from dragonchaser, rhafer, butonic and kobergj and removed request for dragonchaser and rhafer May 18, 2022 13:27
mmattel
mmattel approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmattel mmattel merged commit b10270c into owncloud:master May 18, 2022
ownclouders pushed a commit that referenced this pull request May 18, 2022
@mmattel
commit b10270c
f0f6fd6 
Merge: afb5d41 6958533
Author: Martin <github@diemattels.at>
Date:   Wed May 18 16:32:57 2022 +0200

    Merge pull request #3827 from wkloucek/update-port-ranges-add-debug-config

    update port ranges add debug config
@wkloucek wkloucek deleted the update-port-ranges-add-debug-config branch May 19, 2022 05:35
@micbar micbar mentioned this pull request May 25, 2022
Closed
25 tasks
@wkloucek wkloucek mentioned this pull request Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmattel mmattel mmattel approved these changes

@kobergj kobergj kobergj approved these changes

@dragonchaser dragonchaser Awaiting requested review from dragonchaser

@butonic butonic Awaiting requested review from butonic

@rhafer rhafer Awaiting requested review from rhafer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wkloucek @mmattel @kobergj