Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically created Port Ranges #3595

Closed
mmattel opened this issue Apr 27, 2022 · 10 comments
Closed

Dynamically created Port Ranges #3595

mmattel opened this issue Apr 27, 2022 · 10 comments
Labels
Category:Enhancement Add new functionality

Comments

@mmattel
Copy link
Contributor

mmattel commented Apr 27, 2022

In dev docs, we define Port Ranges. It seems to me that these ranges are created statically and not via a dynamic build process like it is done via the files in https://github.com/owncloud/ocis/tree/docs/extensions/_includes

Proposal: define the port ranges dynamically as we do eg. with env variables and store the result in the above directory

Note that we could omit the free ports, versioning for existing ports is needed (included since, depreciated since).

@dragonchaser
@micbar

@EParzefall FYI

@mmattel mmattel added the Category:Enhancement Add new functionality label Apr 27, 2022
@mmattel
Copy link
Contributor Author

mmattel commented May 2, 2022

Note that the port range list in general needs an update because:

  • idm TBD --> idm has been merged ?
  • accounts --> was removed ?
  • reva unused --> reva reserved (improve naming)
  • photoprism (state: PoC) --> temporary reserved (improve naming)

Note that this is also admin-docs / dev-docs relevant independent if this gets autogenerated in future or not.

@micbar
Copy link
Contributor

micbar commented May 11, 2022

@mmattel From my pov, this is not needed.

  1. In the future, more and more services will resolve by name and not by static routing. Today this is already done with the ocdav service see

    Endpoint: "/remote.php/",
    Service: "com.owncloud.web.ocdav",
    },
    {
    Endpoint: "/dav/",
    Service: "com.owncloud.web.ocdav",
    },
    {
    Endpoint: "/webdav/",
    Service: "com.owncloud.web.ocdav",
    },
    {
    Endpoint: "/status.php",
    Service: "com.owncloud.web.ocdav",
    },
    {
    Endpoint: "/index.php/",
    Service: "com.owncloud.web.ocdav",
    },
    {
    Endpoint: "/apps/",
    Service: "com.owncloud.web.ocdav",

  2. The remaining static ports should not change anymore

@mmattel
Copy link
Contributor Author

mmattel commented May 12, 2022

The remaining static ports should not change anymore

Should...
It is hard to follow up on changes if applied.
I would like to link to a antora styled table in the same way we did for the extensions but for ports. This would eliminate any manual interaction and avoids the should case, dev`s stay free to develop 😃

@mmattel
Copy link
Contributor Author

mmattel commented May 12, 2022

static routing ... already done with the ocdav service...

something relevant for docs?
In case, more work ahaed 😅

@michl19
Copy link
Contributor

michl19 commented May 12, 2022

Moved to "Infinite Scale Beta phase" on request of @mmattel

@mmattel
Copy link
Contributor Author

mmattel commented May 12, 2022

Note, this move is in accordance post a disussion with @dragonchaser in our docs meeting.

@dragonchaser
Copy link
Member

@micbar so does this make sense to implement?

@micbar
Copy link
Contributor

micbar commented May 12, 2022

The docs need an update, but we do not need a automated mechanism

@wkloucek
Copy link
Contributor

https://owncloud.dev/extensions/port-ranges/ seems to be up to date. I updated it after your discussion in #3827 and just learned about this issue right now

@michl19
Copy link
Contributor

michl19 commented Jul 18, 2022

Closed as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
Archived in project
Development

No branches or pull requests

5 participants