Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hardcode config for spaces which was not allowed to change #8303

Merged
merged 1 commit into from Feb 2, 2024

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jan 29, 2024

Description

Stumbled over two environment variables for which even the description states that they are not allowed to be changed. This PR has two positive results:

  • reduced the risk to misconfigure ocis
  • will allow the web team to remove capability checks in web, because ocis is the only allowed backend. Since other clients are checking those capabilities, we can't remove the capabilities entirely.

I consider this to be a bugfix because the description of the env vars hints towards broken ocis if those config variables are set to other values than those which I now hardcoded.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann requested a review from micbar January 29, 2024 09:37
@kulmann kulmann self-assigned this Jan 29, 2024
Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kulmann
Copy link
Member Author

kulmann commented Jan 29, 2024

cc @JammingBen @janackermann if this gets merged we can remove a lot of ifs from the web master

@micbar micbar merged commit e22dce4 into master Feb 2, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-spaces-config-options branch February 2, 2024 09:22
ownclouders pushed a commit that referenced this pull request Feb 2, 2024
fix: hardcode config for spaces which was not allowed to change
@micbar micbar mentioned this pull request Feb 7, 2024
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants