Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

technical dep - remove share jail check #10436

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Feb 2, 2024

Description

Since owncloud/ocis#8303 has been merged, sharing jail will be always enabled, so there is no need for the checks anymore.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

update-docs bot commented Feb 2, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels good to finally get rid of this. In addition to the comments, I saw that you can also just delete the following two functions:

  • buildWebDavFilesPath
  • buildWebDavFilesTrashPath
    both defined in web-client/src/helpers/resource/functions.ts. They are finally unused after your changes. 🥳

Copy link

sonarcloud bot commented Feb 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@AlexAndBear AlexAndBear enabled auto-merge (squash) February 2, 2024 10:43
@AlexAndBear AlexAndBear merged commit 707c674 into master Feb 2, 2024
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-share-jail-check branch February 2, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants