Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spaces enabled checks #10437

Merged
merged 7 commits into from
Feb 2, 2024
Merged

Remove spaces enabled checks #10437

merged 7 commits into from
Feb 2, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Feb 2, 2024 •
edited

Description

Since owncloud/ocis#8303 has been merged, spaces will be always enabled, so there is no need for the checks anymore.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Feb 2, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

kulmann
kulmann approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐

@kulmann kulmann enabled auto-merge (squash) February 2, 2024 12:39
@AlexAndBear AlexAndBear enabled auto-merge (squash) February 2, 2024 15:07
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
84.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear merged commit 19d3664 into master Feb 2, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-spaces-enabled-checks branch February 2, 2024 18:14
@AlexAndBear AlexAndBear mentioned this pull request Feb 5, 2024
Closed
saw-jan added a commit that referenced this pull request Mar 4, 2024
@saw-jan
test: port e2e test code from #10437
adca420
@saw-jan saw-jan mentioned this pull request Mar 4, 2024
Merged
phil-davis added a commit that referenced this pull request Mar 5, 2024
@phil-davis
Merge pull request #10537 from owncloud/port/code-from-10437-10426-10430
f3dfd45 
[tests-only][full-ci][backport ] backport test codes from #10437 and #10426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexAndBear @kulmann