[QA] admin cannot login, when basic_auth_guest_only is true

[jnweiger]

Seen while testing openidconnect 2.2.0-rc.6 with core 10.11.0

• Restrict basic auth to guests only: occ config:system:set openid-connect.basic_auth_guest_only --value true --type boolean
• Try to log in the admin user with basic auth.
• An error occurs. BAD
  

Expected behaviour:

• admin can always log in.

[DeepDiver1975]

Works as designed. Only guests 🤷

[DeepDiver1975]

I suggest to revert #253 and get this release rolling.

We have customers waiting for other features of this release.

@jvillafanez @hodyroff @jnweiger objections

[jvillafanez]

#265 would fix this, but we need to decide what to do with the feature as a whole

[DeepDiver1975]

Absolutly

• blocking/allowing guest login is not the responsibility of the openid connect app from my pov
• adding yet another config switch If basic_auth_guest_only is active, allow groups to bypass the check #265 might be a bit overkill - only one customer is requesting this feature
• lack of decision making is blocking other customers

[DeepDiver1975]

revert pr created ...... so that we are prepares once the decision is there ..... #268

[jnweiger]

I agree with the revert and move everything to work with groups. #265 could carry guests and admin group to fix my case.
The naming of the key in #265 is weird then and should be simplified.

[jnweiger]

@DeepDiver1975
I cannot confirm that the code is working with 2.2.0-rc.7

• occ config:system:set openid-connect.basic_auth_guest_only --value true --type boolean
• Now only admin and guests should be able to log in via basic auth.
• user einstein is neither admin group nor guests group, and can log in. BAD.

With 10.11.0 and openidconnect-2.2.0-rc.7 installed:

/var/www/owncloud# find . -name \*.php | xargs grep basic_auth_guest_only
/var/www/owncloud#

With daily master and openidconnect-2.2.0-rc.7 installed:

/var/www/owncloud# find . -name \*.php | xargs grep basic_auth_guest_only
/var/www/owncloud#

/var/www/owncloud# find . -name *.php | xargs grep basic_auth_guest_only
./config/config.apps.sample.php: * Possible keys: openid-connect.basic_auth_guest_only BOOL
./config/config.apps.sample.php:'openid-connect.basic_auth_guest_only' => false,
./config/config.php: 'openid-connect.basic_auth_guest_only' => true,
/var/www/owncloud#

[DeepDiver1975]

We removed this feature. It will be implemented in core. Out of scope