Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

getFileContents fails on images #45

Open
zeidlos opened this issue Feb 6, 2018 · 1 comment
Open

getFileContents fails on images #45

zeidlos opened this issue Feb 6, 2018 · 1 comment

Comments

@zeidlos
Copy link

zeidlos commented Feb 6, 2018

https://github.com/noveens/js-owncloud-client/blob/4395837f02ee4700675fabbbb06dd9b1292e3c1a/owncloud/fileManagement.js#L78

Observed behavior:
oc.files.getFileContents(file.name) returns a string that is much bigger than the image it should return.

A 1.2MB (fs size) image returns as 2.2MB String.

Desired behavior:
It should pipe the content 1:1.

Maybe I am not getting something very important here and this issue is just garbage, but please let me know.

Meta:
Trying to create a proxy for owncloud hosted images. So xy.z/slideshow returns an object with all the images in a special folder and xy.z/slideshow/1 returns the first image as an image, not as an url. And here it breaks. Sadly it's in a private repository. Syncing the ownCloud is not really a desired option.

@noveens
Copy link
Contributor

noveens commented Mar 13, 2018

Hey @zeidlos ,

Sorry for the late reply, can't seem to find an email from GitHub.
I'd try to find and solve the issue you mentioned, but unfortunately, I have been a little busy because of my university.

But yeah, if you have some free time on your hand, PRs are welcome! 😉

@DeepDiver1975 DeepDiver1975 self-assigned this Apr 24, 2019
@DeepDiver1975 DeepDiver1975 removed their assignment Sep 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants