Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better looking updater in admin section. #171

Merged
merged 2 commits into from
Sep 11, 2015
Merged

Conversation

raghunayyar
Copy link
Member

A fix for : #170

I have altered the spacing for the note block-quote, though I have retained the grey background. I think it should stay. All other semantic fixes lie in this PR.

cc @karlitschek @jancborchardt @owncloud/designers


.updater-update h3 {
font-weight:bold;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h3 should not be bold

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is, actually there should be no custom h styles at all. The h3 from core should suffice.

@raghunayyar
Copy link
Member Author

@jancborchardt updated.

@karlitschek
Copy link

Definitely better 👍 Not perfect. What do you think @jancborchardt
pdater

@jancborchardt
Copy link
Member

Yeah, it’s definitely better. The next step is to cut down the text from being so incredibly verbose to something more concise.

@karlitschek
Copy link

@jancborchardt +1

@raghunayyar
Copy link
Member Author

Will that be the part of the same Pull Request? @jancborchardt @karlitschek

@jancborchardt
Copy link
Member

No, small steps. Is this one good to go from your POV @raghunayyar?

@raghunayyar
Copy link
Member Author

@jancborchardt the only thing which looks odd to me at the moment is the padding the Note has from the top of the grey block. Else, I think it is good to go.

@jancborchardt
Copy link
Member

@raghunayyar maybe just cut the »Note« heading? Or directly the whole container around it as well?

@raghunayyar
Copy link
Member Author

@jancborchardt just the note heading, because it gets 2 padding / margins . One from the box and the other from the heading. I will look into it asap push.

@raghunayyar
Copy link
Member Author

@jancborchardt @karlitschek now this is complete from my end. Need a couple of 👍 here.

@karlitschek
Copy link

Hmm. 👍 If this is the best we can do. Still not really elegant but O.K.

@karlitschek
Copy link

@jancborchardt FYI

u

jancborchardt added a commit that referenced this pull request Sep 11, 2015
Better looking updater in admin section.
@jancborchardt jancborchardt merged commit cbb5458 into master Sep 11, 2015
@jancborchardt jancborchardt deleted the prettyfy-updater branch September 11, 2015 08:00
@jancborchardt
Copy link
Member

👍 any further enhancements are for future PRs. :)

@jancborchardt jancborchardt added this to the 8.2-current milestone Sep 11, 2015
@jancborchardt
Copy link
Member

Here’s a follow-up issue about reducing the amount of text: #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants