-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better looking updater in admin section. #171
Conversation
|
||
.updater-update h3 { | ||
font-weight:bold; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h3 should not be bold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is, actually there should be no custom h styles at all. The h3 from core should suffice.
18233a3
to
a449028
Compare
@jancborchardt updated. |
Definitely better 👍 Not perfect. What do you think @jancborchardt |
Yeah, it’s definitely better. The next step is to cut down the text from being so incredibly verbose to something more concise. |
Will that be the part of the same Pull Request? @jancborchardt @karlitschek |
No, small steps. Is this one good to go from your POV @raghunayyar? |
@jancborchardt the only thing which looks odd to me at the moment is the padding the Note has from the top of the grey block. Else, I think it is good to go. |
@raghunayyar maybe just cut the »Note« heading? Or directly the whole container around it as well? |
@jancborchardt just the note heading, because it gets 2 padding / margins . One from the box and the other from the heading. I will look into it asap push. |
@jancborchardt @karlitschek now this is complete from my end. Need a couple of 👍 here. |
Hmm. 👍 If this is the best we can do. Still not really elegant but O.K. |
@jancborchardt FYI |
Better looking updater in admin section.
👍 any further enhancements are for future PRs. :) |
Here’s a follow-up issue about reducing the amount of text: #172 |
A fix for : #170
I have altered the spacing for the note block-quote, though I have retained the grey background. I think it should stay. All other semantic fixes lie in this PR.
cc @karlitschek @jancborchardt @owncloud/designers