Skip to content

Commit

Permalink
Transform route titles into real h1's, for #1651
Browse files Browse the repository at this point in the history
Use generic visually hidden, page title helper class, established in DS for #1651
  • Loading branch information
marcus-herrmann committed Oct 7, 2019
1 parent 2b364a1 commit 36d4978
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion apps/files/src/components/FilesAppBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@
</div>
<span class="uk-flex uk-flex-middle" v-if="!showBreadcrumb">
<oc-icon v-if="pageIcon" :name="pageIcon" class="uk-margin-small-right" />
<span class="uk-text-lead">{{pageTitle}}</span>
<h1 class="oc-page-title">{{pageTitle}}</h1>
</span>
<span v-else-if="showBreadcrumb">
<h1 class="oc-visually-hidden">{{pageTitle}}</h1>
</span>
</div>
<div v-show="inProgress.length > 0" class="uk-width-auto">
Expand Down
2 changes: 1 addition & 1 deletion src/pages/account.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<oc-loader v-if="loading" />
<div v-if="!loading" class="uk-width-3-4@m uk-container uk-padding">
<div class="uk-flex uk-flex-between uk-flex-middle">
<span class="uk-text-lead" v-translate>Account</span>
<h1 class="uk-text-lead oc-page-title" v-translate>Account</h1>
<oc-button icon="exit_to_app" @click="$_oc_settingsAccount_logout"><translate>Logout</translate></oc-button>
</div>
<hr />
Expand Down

0 comments on commit 36d4978

Please sign in to comment.