Merge pull request #4430 from owncloud/copy-nav-item-state

Copy nav item state
owncloud · Dec 8, 2020 · 8d1c7ef · 8d1c7ef
2 parents 111569d + ecc99fe
commit 8d1c7ef
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/changelog/unreleased/fix-nav-item-state b/changelog/unreleased/fix-nav-item-state
@@ -0,0 +1,6 @@
+Bugfix: Copy dynamicNavItems state
+
+The dynamicNavItems state in ADD_NAV_ITEM mutation now gets copied instead of referenced to trigger a state change.
+
+https://github.com/owncloud/ocis/issues/1031
+https://github.com/owncloud/phoenix/pull/4430
diff --git a/src/store/navigation.js b/src/store/navigation.js
@@ -30,7 +30,7 @@ const mutations = {
    * @constructor
    */
   ADD_NAV_ITEM(state, { extension, navItem }) {
-    const dynamicNavItems = state.dynamicNavItems
+    const dynamicNavItems = { ...state.dynamicNavItems }
     dynamicNavItems[extension] = dynamicNavItems[extension] || []
     const index = dynamicNavItems[extension].findIndex(item => item.name === navItem.name)
     if (index >= 0) {