Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy nav item state #4430

Merged
merged 3 commits into from Dec 8, 2020
Merged

Copy nav item state #4430

merged 3 commits into from Dec 8, 2020

Conversation

fschade
Copy link
Collaborator

@fschade fschade commented Dec 7, 2020

@update-docs
Copy link

update-docs bot commented Dec 7, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@fschade fschade requested a review from kulmann December 7, 2020 17:25
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 🚀

Please remove the writeToDisk config option. Should not be in scope of this PR. And I don't want to have it without setting up a ramdisk first.

Also, please add a changelog. The fix is worth being mentioned. ;-)

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! ❤️ You need to sign the CLA, then we can merge this PR.

@fschade fschade merged commit 8d1c7ef into master Dec 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the copy-nav-item-state branch December 8, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings: No entries in the sidebar after login
3 participants