Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White boxes during thumbnail rendering #5407

Closed
wkloucek opened this issue Jun 28, 2021 · 10 comments
Closed

White boxes during thumbnail rendering #5407

wkloucek opened this issue Jun 28, 2021 · 10 comments
Assignees
Labels
Browser:Chrome Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@wkloucek
Copy link
Contributor

Steps to reproduce

  1. run oCIS 1.8.0-RC1
  2. create a folder with a bunch of pictures
  3. navigate to that folder

Expected behaviour

Thumbnail placeholder is replaced by the actual thumbnail when available

Actual behaviour

Thumbnail placeholder is replaced by white box and later replaced by the actual thumbnail.

Peek.2021-06-28.15-38.mp4

Server configuration

oCIS: 1.8.0-RC1 -> ownCloud Web: 3.3.0

Client configuration

Browser: Chromium Version 91.0.4472.114

@wkloucek wkloucek added Type:Bug Something isn't working Browser:Chrome labels Jun 28, 2021
@wkloucek
Copy link
Contributor Author

@fschade looks like some browser behave differently :-/

@fschade
Copy link
Collaborator

fschade commented Jul 12, 2021

@wkloucek thanks, good catch. I take care

@wkloucek
Copy link
Contributor Author

wkloucek commented Sep 1, 2021

Still persists in Web 4.1.0

@kulmann
Copy link
Member

kulmann commented Dec 3, 2021

Still persists in web 4.5.0 and upcoming 4.6.0

@kulmann kulmann added the Priority:p2-high Escalation, on top of current planning, release blocker label Dec 3, 2021
@dschmidt
Copy link
Member

AFAICT this is an issue (at least) in Chrome with blob: urls.

With the current implementation in

return window.URL.createObjectURL(data)

loading a file list with thumbnails looks like this for me (Chromium 95):

liveview-2021-12-11_16.32.53.mp4

Replacing the blob url with a data url, using blobToDataUrl from https://stackoverflow.com/a/67551175/2886832

    return blobToDataURL(data)

The flickering is gone for me:

liveview-2021-12-11_16.33.47.mp4

Obviously that is pushing way more data through the store, so I'm not sure this is a desirable solution.

What do you think: how should we progress from here?

@dschmidt
Copy link
Member

Possibly related: #5119 #5796

@lookacat lookacat self-assigned this May 16, 2022
@lookacat
Copy link
Contributor

LGTM 👍🏼 would close the issue if there is nothing left

@kulmann kulmann added Priority:p3-medium Normal priority and removed Priority:p2-high Escalation, on top of current planning, release blocker labels Jul 8, 2022
@kulmann
Copy link
Member

kulmann commented Jul 8, 2022

LGTM 👍🏼 would close the issue if there is nothing left

🤔 the issue is not solved at all. can't close it. @dschmidt I'd not like to push more data into the store. Prio is not that high though, so let's put some more thought into it when we cleaned up the store further.

@wkloucek
Copy link
Contributor Author

I tested with Web 5.7.0-rc.5 and it looks way better than with 3.3.0. (Although it does not feel too snappy)

Peek.2022-07-18.07-46.mp4

@wkloucek
Copy link
Contributor Author

I couldn't reproduce with Web 7.0.1 and oCIS 3.1.0-next.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser:Chrome Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants