feat: add shared by filter on 'Shared with me'-page #10029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The share type properties are getters which the `ItemFilter` component can't handle. Hence we need to compute new objects that have the relevant information as props.
JammingBen
force-pushed
the
shared-by-filter
branch
3 times, most recently
from
923a3db
to
814879a
Compare
kulmann
reviewed
Nov 22, 2023
JammingBen
force-pushed
the
shared-by-filter
branch
from
814879a
to
31121ab
Compare
|
Kudos, SonarCloud Quality Gate passed! |
AlexAndBear
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a "Shared by"-filter to the received shares on the "Shared with me"-page. Also fixes a bug where the share type labels were empty inside the "Share type"-filter and ensures to always show it.
Screenshot
Related Issue
Types of changes