Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share type labels in filter are not showing #10027

Closed
JammingBen opened this issue Nov 21, 2023 · 5 comments · Fixed by #10029
Closed

Share type labels in filter are not showing #10027

JammingBen opened this issue Nov 21, 2023 · 5 comments · Fixed by #10029
Assignees
Labels
Type:Bug Something isn't working

Comments

@JammingBen
Copy link
Collaborator

Steps to reproduce

  1. as admin, share one file with einstein and one file with the group users
  2. as einstein, go to the "Shared with me" page and open the share types filter -> the options don't have a label
image
@JammingBen JammingBen added the Type:Bug Something isn't working label Nov 21, 2023
@JammingBen JammingBen self-assigned this Nov 21, 2023
@dschmidt

This comment was marked as outdated.

@tbsbdr
Copy link
Contributor

tbsbdr commented Nov 22, 2023

I missed, that we have a share type-filter 😄
Trying to guess the userstory - what would it be?
"As a user I want to see only shares that had been shared with a group so that .." @kulmann @JammingBen what do you think? My assumption is that a share type filter is seldom helpful, do you think different?

@JammingBen
Copy link
Collaborator Author

We primarily built it to filter for federated shares and thought "well, might be useful to filter group-shares as well" 😄

@kulmann
Copy link
Member

kulmann commented Nov 22, 2023

And federated shares are on the horizon, so let's keep it...

But, I noticed that the share type filter is searchable. That's not needed, as it will only show 1-3 filter options (user/group/federated).

@tbsbdr
Copy link
Contributor

tbsbdr commented Nov 23, 2023

hm, I don't get why filtering by share-type is useful for regular users but ok, lets try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants