perf: speed up folder tree creation during upload #10057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
approved these changes
Nov 23, 2023
JammingBen
force-pushed
the
create-folder-tree-performance
branch
from
753cf92
to
62d531c
Compare
Speeds up the folder tree creation during upload by running the process asynchronously and by saving up PROPFIND requests on nested folders.
JammingBen
force-pushed
the
create-folder-tree-performance
branch
from
62d531c
to
494ef9a
Compare
|
Kudos, SonarCloud Quality Gate passed! |
dschmidt
approved these changes
Nov 24, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Speeds up the folder tree creation during upload by running the process asynchronously and by saving up PROPFIND requests on nested folders.
In my test with a folder including 155 sub folders the time for creating those decreased from 20-30 seconds to 5-7. That's still quite a bit, but most likely as good as it can get when doing this on the client-side.
Related Issue
Types of changes