Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: register file quick actions as extensions #10102

Merged
merged 2 commits into from Dec 1, 2023
Merged

refactor: register file quick actions as extensions #10102

merged 2 commits into from Dec 1, 2023

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Dec 1, 2023 •
edited

Description

The quick actions in the files app are now registered as extension via our extension registry. They are of type action and have the files.quick-action scope. This allows us to work with the quick actions more easily and more flexible, e.g. we can use the new action for creating links. Also, we can now use the existing actions for creating links and opening the sharing panel.

Note for developers: This change officially deprecates the old way of registering quick actions via the quickaction property of an app.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Dec 1, 2023
@JammingBen JammingBen marked this pull request as ready for review December 1, 2023 09:36
@JammingBen JammingBen force-pushed the quickActionsInjectionContext branch 2 times, most recently from 38ae54f to 885a037 Compare December 1, 2023 10:14
@JammingBen JammingBen changed the title refactor: move quick actions into injection context refactor: register file quick actions as extensions Dec 1, 2023
@JammingBen JammingBen force-pushed the quickActionsInjectionContext branch 2 times, most recently from 9d061a0 to 45726f1 Compare December 1, 2023 10:25
@owncloud owncloud deleted a comment from update-docs bot Dec 1, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 39 Code Smells

38.2% 38.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

dschmidt
dschmidt approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsurprisingly I love it

@JammingBen JammingBen merged commit ff110ff into master Dec 1, 2023
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the quickActionsInjectionContext branch December 1, 2023 12:37
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt approved these changes

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JammingBen @dschmidt