Readonly versions panel #10182
Merged
Readonly versions panel #10182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAndBear
reviewed
Dec 14, 2023
kulmann
force-pushed
the
readonly-versions-panel
branch
from
926bdfd
to
f0ce16e
Compare
kulmann
force-pushed
the
readonly-versions-panel
branch
from
f0ce16e
to
0a1e719
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make versions panel readonly when the right sidebar is opened from within a viewer or editor.
Reason for that is that it would require complex user interaction to make reverting versions from within an editor view (= the file content is already displayed) possible. Let's avoid that by only allowing the download action, not the revert action.
Types of changes
Checklist: