Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scope when clicking "Show n results" #10653

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix: scope when clicking "Show n results" #10653

merged 1 commit into from
Mar 22, 2024

Conversation

JammingBen
Copy link
Collaborator

Description

Prevents the search scope from getting lost when clicking "Show n results" in the search preview.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Mar 21, 2024
@saw-jan
Copy link
Member

saw-jan commented Mar 21, 2024

FYI: I restarted the build because I removed the ocis cache. because of #10651 (comment)

@saw-jan
Copy link
Member

saw-jan commented Mar 21, 2024

@JammingBen Could you rebase this PR?

features/webUIFilesList
features/webUIFilesDetails
Invalid suite: features/webUIFilesList

suite webUIFilesList was removed recently

@JammingBen
fix: scope when clicking "Show n results"
c5c0ab8 
Prevents the search scope from getting lost when clicking "Show n results" in the search preview.
@JammingBen
Copy link
Collaborator Author

Rebased, thanks for the hint!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

kulmann
kulmann approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JammingBen JammingBen merged commit 2fbc69e into stable-8.0 Mar 22, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-show-result-scope branch March 22, 2024 08:44
@JammingBen JammingBen mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JammingBen @saw-jan @kulmann @AlexAndBear