Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar multi root panels #11037

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Sidebar multi root panels #11037

merged 3 commits into from
Jun 13, 2024

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jun 13, 2024

Description

This PR makes it possible to display multiple root panels in the right sidebar - just below each other, with a separator line. I've decided against rendering the panel titles above the additional root panels, that looked quite disruptive.

Related Issue

Screenshots

For development and for this screenshot I've made the Image Info (Exif) panel a root panel. That's not committed into this branch, the exif panel will stay a sub panel like before.

Screenshot 2024-06-13 at 06 22 13

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Pretty sure that the combination of css classes / selectors is not
possible at all, and I didn't find a visual difference.

This comment was marked as resolved.

Copy link

sonarcloud bot commented Jun 13, 2024

@kulmann kulmann self-assigned this Jun 13, 2024
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kulmann kulmann merged commit f892da5 into master Jun 13, 2024
3 checks passed
@kulmann kulmann deleted the sidebar-multi-root-panels branch June 13, 2024 14:55
@micbar micbar mentioned this pull request Jun 19, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants