Adjusted changelog and version to 0.2.5 #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
reviewed
Oct 25, 2019
CHANGELOG.md
Outdated
| - Rename and delete will be disallowed in case the parent folder has no permissions fot these two operations https://github.com/owncloud/phoenix/pull/2129 | ||
| - Acceptance tests for deleting shared files and deleting shares https://github.com/owncloud/phoenix/pull/2140 | ||
| - Reject promise if invalid response during permalink check in acceptance tests https://github.com/owncloud/phoenix/pull/2141 | ||
| - Acceptance test for checking delete button state when prohibiting deleting in share https://github.com/owncloud/phoenix/pull/2146 |
There was a problem hiding this comment.
note that for core I usually would not add any entries that only add tests, not sure if we should that the same here
LukasHirt
force-pushed
the
release/25102019
branch
2 times, most recently
from
41fc10d
to
62775d4
Compare
PVince81
reviewed
Oct 25, 2019
CHANGELOG.md
Outdated
| ### Added | ||
| - Run tests on internet explorer https://github.com/owncloud/phoenix/pull/2082 | ||
| - Draw.io app integration https://github.com/owncloud/phoenix/pull/2083 | ||
| - Logout step for acceptance tests https://github.com/owncloud/phoenix/pull/2100 |
There was a problem hiding this comment.
also remove test entries such as these ?
LukasHirt
force-pushed
the
release/25102019
branch
from
62775d4
to
00c77b0
Compare
Moved few PRs to different sections Removed tests from changelog Removed last tests items Changed wording of ie 11 tests
LukasHirt
force-pushed
the
release/25102019
branch
from
00c77b0
to
c5fbed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.