Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling tweaks for share indicators and indirect share entries #2940

Merged
merged 6 commits into from
Jan 31, 2020
Merged

Styling tweaks for share indicators and indirect share entries #2940

merged 6 commits into from
Jan 31, 2020

Commits on Jan 30, 2020

  1. Align collaborator avatar size 

    The oc-icon size for the group and person icons is 48px.
This fix changes the avatar size from 50px to 48px to make sure all are
properly aligned in both the collaborators list and the autocomplete
items.
    Vincent Petry committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    07d6bd9 View commit details
    Browse the repository at this point in the history

  2. Remove section headers in collaborators and links panels 

    Remove the section headers in the collaborators and link share panels
and adjusted the divider lines to be consistent across the sections.
    Vincent Petry committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    a1bc114 View commit details
    Browse the repository at this point in the history

  3. Hide lock icon in collaborators and link share lists 

    The lock icon felt redundant so it is now made invisible to keep the
layout and alignment with other entries that display a delete icon.
    Vincent Petry committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    bbf2571 View commit details
    Browse the repository at this point in the history

  4. Adjust reshare and via information in share rows 

    Move the via label to the bottom of the collaborator and link row.
For collaborators, the reshare information still appears on top.
    Vincent Petry committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    1dabd8f View commit details
    Browse the repository at this point in the history

  5. Keep share indicator position in file list 

    Collaborator and link share indicators in the file list are now always
staying in their own "column" or position instead of following each
other.

This is achieved by always rendering the indicator but hiding it with
uk-invisible to keep the empty space's size.
    Vincent Petry committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    6b96846 View commit details
    Browse the repository at this point in the history

  6. Fix margins on table rows in share/link list items.

    @kulmann
    kulmann committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    f618777 View commit details
    Browse the repository at this point in the history