Fix l10n process #3014
Fix l10n process #3014
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
The mistake was passing in the result of $gettext() instead of the function itself. This caused `make l10n-read` to fail because of the missing argument. For consistency, this commit also adjusts the function name used in the action to also be called $gettext, to make sure the text to translate will be found by the l10n tools as well.
Whenever an error occurs, we need to fail hard so we can catch translation sync issues early.
PVince81
force-pushed
the
fix-l10n-proces
branch
from
8b0719f
to
334ac1a
Compare
| @@ -819,12 +819,12 @@ export default { | |||
| .then(_ => { | |||
| context.dispatch('loadFolderSharedWithMe', { | |||
| client: client, | |||
| $gettext: translate | |||
| $gettext: $gettext | |||
There was a problem hiding this comment.
You can just write $gettext here, no key: value required.
|
It might be good to run make l10n-read in each and every PR to detect if there is something wrong with respect to translations ..... |
The likeliness of this happening is rather low I think, so won't add it. However, unskipping errors for push/pull would be able to catch a broader scope of potential sync issues in the future. |
Generally speaking: catching an error on PR level is better then days later on the translation sync job (which is monitored by whom? 🤷♂️ ) |
|
and compared to the time we spend on all the acceptance tests this is a rather small job ... |
|
anyway - your project - your decision 💪 |
Description
Related Issue
Fixes #3012
Motivation and Context
How Has This Been Tested?
Run
make l10n-readand see that the error is gone.Screenshots (if appropriate):
Types of changes
Checklist: