Translation sync job must fail in case of error

[PVince81]

See https://drone.owncloud.com/owncloud/translation-sync/1431/31/5 at line 368.

There's an error:

tx ERROR: [Errno 2] No such file or directory: '/drone/src/phoenix/apps/files/l10n/template.pot'

and yet the job continues as if all was well.

[DeepDiver1975]

The real issue is in another step https://drone.owncloud.com/owncloud/translation-sync/1431/31/4

[DeepDiver1975]

run locally

make l10n-read

[DeepDiver1975]

there is something wrong with the strings in apps/files/src/store/state.js

[PVince81]

Reproducible locally. I'll bisect to see what's wrong.

[PVince81]

0.3.0 and 0.2.0 are broken.

I wasn't able to run make l10n-read on the first Makefile commit that introduced the command.

Either it's an env issue like upgraded node or the problem existed since a while and did not get discovered.

[PVince81]

Okay, so if bisect cannot help here, next step is adding more log statements in that tool to find out what location is affected

[PVince81]

Found it:

40 { msgid: undefined,
  msgctxt: null,
  references:
   [ '../apps/files/src/components/Collaborators/SharedFilesList.vue:151' ],
  msgid_plural: undefined,
  msgstr: [],
  comments: [],
  extractedComments: [],
  flags: {},
  obsolete: false,
  nplurals: 2 }

[PVince81]

a $gettext() call without arguments 😱

Fix is here: #3014