File drop is disabled in case the folder is ready only or no space is…

[DeepDiver1975]

… left

Description

In case a folder is read only or not enough space is left file drop is being disabled.

Related Issue

https://jira.owncloud.com/browse/XLXFN-17

How Has This Been Tested?

• share a folder readonly with another user A
• A wants to drop files from desktop to the browser with this folder
• no drop zone shall be visible

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• ...

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[DeepDiver1975]

adding changelog entry

[DeepDiver1975]

False failure? https://drone.owncloud.com/owncloud/phoenix/10196/5/19 🤷

[LukasHirt]

False failure? drone.owncloud.com/owncloud/phoenix/10196/5/19 🤷

Not sure seems that it failed also for the first commit without changelog - https://drone.owncloud.com/owncloud/phoenix/10194/5/19

[DeepDiver1975]

Restarting once again ....

[DeepDiver1975]

@LukasHirt how shall we continue with this? I have no clue what is causing the failing test ... 🤷‍♂️

[LukasHirt]

@DeepDiver1975 I pushed a new commit which should fix the failing test. In the console was an error about not being able to use indexOf in the hasFreeSpace computed prop after permissions. Not sure why this blocked rendering of the delete batch action but fixing this error seems to work fine 🤷

[LukasHirt]

I adjusted the commit not to use optional chaining because it seems to be throwing errors when extracting translations (ref #3733)