Stop using nullish coalescing operator and optional chaning #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
@phil-davis This PR only fixes errors happening when extracting translations. Not sure if it will also fix the error with push since I cannot run that locally. |
10 tasks
kulmann
requested changes
Jul 6, 2020
kulmann
approved these changes
Jul 6, 2020
| @@ -85,7 +85,11 @@ export default { | |||
| }, | |||
|
|
|||
| currentTab() { | |||
| return this.currentSidebarTab?.tab || this.defaultTab | |||
| if (this.currentSidebarTab) { | |||
There was a problem hiding this comment.
What about if(this.currentSidebarTab && this.currentSidebarTab.tab) { here? Feels a bit weird to have to fallbacks to the same variable in place. ;-)
|
|
||
| return panel || PANEL_SHOW | ||
| if (tabOptions) { |
There was a problem hiding this comment.
Same here, you could go with if (tabOptions && tabOptions.collaboratorsCurrentPanel) { to avoid falling back to the same value in two different places.
Using Nullish coalescing operator and optional chaining resulted in syntax errors in translations sync.
LukasHirt
force-pushed
the
bugfix/translations-sync
branch
from
98c8761
to
773dbf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using Nullish coalescing operator and optional changing resulted in syntax errors in translations sync.
Related Issue
Motivation and Context
Passing translations sync
How Has This Been Tested?
Run
make l10n-read