Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file editor actions #4436

Merged
merged 2 commits into from Dec 8, 2020
Merged

Fix file editor actions #4436

merged 2 commits into from Dec 8, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Dec 8, 2020

Description

The checks on which route an extension is enabled were not active (and inverted). We fixed this so that editors only appear on configured routes now.

Related Issue

Motivation and Context

Hardening

How Has This Been Tested?

  • drone

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann added the Status:Needs-Review Needs review from a maintainer label Dec 8, 2020
@kulmann kulmann self-assigned this Dec 8, 2020
LukasHirt
LukasHirt approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kulmann kulmann merged commit 1a57516 into master Dec 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-file-editor-actions branch December 8, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

Assignees

@kulmann kulmann

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[oC-Web] files default action in right sidebar of trashbin
2 participants
@kulmann @LukasHirt