[unit-tests-only] collaboratorType() of packages/web-app-files/src/mixins/collaborators.js #5285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiranparajuli589
approved these changes
Jun 17, 2021
individual-it
commented
Jun 17, 2021
| ${0} | ${'User'} | ||
| ${1} | ${'Group'} | ||
| ${2} | ${'Unknown type'} | ||
| ${3} | ${'Unknown type'} |
There was a problem hiding this comment.
this is a public link share, but I guess Unknown type is correct here because this in used in the collaborators/people list and the public links are displayed separately
@kulmann is that true?
individual-it
force-pushed
the
UnitTestCollaboratorType
branch
from
ce7bf20
to
b7c0b46
Compare
…xins/collaborators.js
individual-it
force-pushed
the
UnitTestCollaboratorType
branch
from
b7c0b46
to
19735f5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
LukasHirt
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
unit tests for the collaborator type in the collaborators mixins
Related Issue
part of #5234
How Has This Been Tested?
yarn run test:unitScreenshots (if appropriate):
Types of changes
Checklist:
Open tasks: