Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External apps by shares #5907

Merged
merged 5 commits into from
Oct 18, 2021
Merged

External apps by shares #5907

merged 5 commits into from
Oct 18, 2021

Conversation

elizavetaRa
Copy link
Member

@elizavetaRa elizavetaRa commented Oct 14, 2021

Description

  • Enabling external apps by shared with me files. Accepted shares with the corresponding mimetypes have "open with" as actions
  • Fixing bug by context actions for shares (the property id is passed instead of fileId and they are not the same by shares)

Related Issue

Motivation and Context

I should be able to collaborate on files shared with me if permission allows!

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • [x ] Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Oct 14, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pascalwengerter
Copy link
Contributor

@elizavetaRa could you add a bugfix changelog item within this PR? And running yarn lint --fix before committing checks your code locally already :)

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, code looks good, but the changelog works differently. Instead of writing to the CHANGELOG.md, please write a changelog item. Just have a look at the changelog folder, in the unreleased subfolder or one of the versioned subfolders. You can copy any bugfix changelog file into the unreleased folder and adapt it to the contents of your PR. During the next release it will be used to generate the CHANGELOG.md.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👏

@kulmann
Copy link
Member

kulmann commented Oct 15, 2021

Unit tests are failing. Could you please add fileId: 'a93f8adf==', in line 252 of ContextActions.spec.js?

@ownclouders
Copy link
Contributor

Results for oC10iPhone2 https://drone.owncloud.com/owncloud/web/19722/46/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter
Copy link
Contributor

pascalwengerter commented Oct 15, 2021

Probably needs a rebase since #5806 got merged

 id is not the same by shares as by normal files, taking fileId fixes the problem with opening by external apps
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

30.1% 30.1% Coverage
0.5% 0.5% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/19766/11/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@pascalwengerter pascalwengerter merged commit 6aa6e7e into owncloud:master Oct 18, 2021
@pascalwengerter
Copy link
Contributor

Tested it, works like a charm 👌🏽

@elizavetaRa elizavetaRa deleted the fix branch May 31, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared with me files can't be opened with external apps
4 participants