[full-ci] feat: move expiration date to a drop

[LukasHirt]

Open tasks:

• Add changelog
• Move v-calendar to ODS
• Release & update ODS
• Fix tests
• Write unit tests
• Discuss clear button

[ownclouders]

Results for oC10SharingInternalGroups https://drone.owncloud.com/owncloud/web/19144/22/1
The following scenarios passed on retry:

• webUISharingInternalGroups/shareWithGroups.feature:255

[ownclouders]

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/19182/24/1
The following scenarios passed on retry:

• webUISharingInternalGroupsToRootSharingIndicator/shareWithGroups.feature:104

[ownclouders]

Results for oCISRename https://drone.owncloud.com/owncloud/web/19218/48/1
The following scenarios passed on retry:

• webUIRenameFolders/renameFolders.feature:79

[ownclouders]

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/19218/27/1
The following scenarios passed on retry:

• webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:154
• webUISharingInternalUsersToRootSharingIndicator/shareWithUsers.feature:98

[ownclouders]

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19218/12/1
The following scenarios passed on retry:

• webUIFilesActionMenu/versions.feature:36

[lookacat]

sure

[ownclouders]

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19592/12/1
The following scenarios passed on retry:

• webUIFilesActionMenu/versions.feature:36

[ownclouders]

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19624/12/1
The following scenarios passed on retry:

• webUIFilesActionMenu/versions.feature:15

[lookacat]

[pascalwengerter]

This PR in general looks good to me, but is a good example of why we should move into smaller PRs for better review-ability - this one could have been divided into OCS update, unit test refactoring, share-date related simplification and then the feature of replacing the Datepicker component itself (just as a suggestion)

Also, apart from the smaller comments I added and which I wouldn't consider show-stoppers, I'm not quite sure how to feel about deleting all those acceptance tests that check the share expiry settings by OC10 admins

[ownclouders]

Results for oC10Sharing1 https://drone.owncloud.com/owncloud/web/19630/16/1
The following scenarios passed on retry:

• webUISharingExpirationDate/shareWithExpirationDate.feature:14

[ownclouders]

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19630/12/1
The following scenarios passed on retry:

• webUIFilesActionMenu/versions.feature:36

[kulmann]

One major thing: could you adapt the expiration date handling in links (create/edit public links) so that it looks the same as for user shares? Ideally by reusing the same component... if too much work we can keep it like it is.

[kulmann]

Can't you use string formatting on the date to achieve the same result? Probably makes sense to just append the time ( 00:00:00), but for the date it looks weirdly handcrafted / hacky.

[lookacat]

its actually copied from calculateDate in sharingHelper so the dates actually match but i can't use that function sadly, but i don't get why the calculateDate has to be this weird

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

47.8% Coverage
0.0% Duplication