Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tus upload for password protected public links #6890

Merged
merged 3 commits into from May 6, 2022
Merged

Enable tus upload for password protected public links #6890

merged 3 commits into from May 6, 2022

Conversation

JammingBen
Copy link
Collaborator

Description

Continuation of #6202

Can now be done because owncloud/ocis#3703 has been merged.

Related Issue

@JammingBen JammingBen self-assigned this May 6, 2022
@JammingBen JammingBen mentioned this pull request May 6, 2022
Closed
10 tasks
@owncloud owncloud deleted a comment from update-docs bot May 6, 2022
@JammingBen JammingBen mentioned this pull request May 6, 2022
Closed
@JammingBen JammingBen marked this pull request as ready for review May 6, 2022 07:24
@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label May 6, 2022
@pascalwengerter
Copy link
Contributor

@JammingBen could you add a commit bump to this PR? Pretty sure said PR has only been merged after the time of the currently linked oCIS commit ID

pascalwengerter
pascalwengerter approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's see if we need to adjust expected failures in tests at some point, but I don't think so

@sonarcloud
Copy link

sonarcloud bot commented May 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@JammingBen JammingBen merged commit 6cdeeaa into master May 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the tus-upload-public-links branch May 6, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@micbar micbar micbar approved these changes

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees

@JammingBen JammingBen

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JammingBen @pascalwengerter @kulmann @micbar