Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent 'Create Space'-button from disappearing when sidebar is open #6919

Merged
merged 1 commit into from
May 10, 2022
Merged

Prevent 'Create Space'-button from disappearing when sidebar is open #6919

merged 1 commit into from
May 10, 2022

Conversation

JammingBen
Copy link
Collaborator

Description

We've fixed a bug where the "Create Space"-button would disappear when opening the sidebar for a space.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this May 9, 2022
@ownclouders
Copy link
Contributor

ownclouders commented May 9, 2022 •
edited
Loading

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/25455/67/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@JammingBen JammingBen force-pushed the create-space-with-open-sidebar branch from edb4465 to 2eb2252 Compare May 10, 2022 07:23
@sonarcloud
Copy link

sonarcloud bot commented May 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 561c719 into master May 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the create-space-with-open-sidebar branch May 10, 2022 08:04
@kulmann kulmann mentioned this pull request May 25, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opening the sidebar for a space removes the "Create Space" button
3 participants
@JammingBen @ownclouders @kulmann