Multiple fixes #6954
Multiple fixes #6954
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
elizavetaRa
force-pushed
the
upstream_fixes
branch
2 times, most recently
from
88dd943
to
b3a0348
Compare
elizavetaRa
force-pushed
the
upstream_fixes
branch
from
b3a0348
to
c32fab6
Compare
|
@pascalwengerter @fschade we did some small fixes across the app. Is it ok to create a cumulative issue & pr for them? |
| height: calc(100% - 42px); | ||
| } | ||
|
|
||
| #text-editor-input { |
There was a problem hiding this comment.
Why not use the oc-height-1-1 for this element also and remove the custom style rule? :)
There was a problem hiding this comment.
If I set the class, it sets the div around <textarea> to 100% but not <textarea> itself. So the class passing would need to be implemented in ocTextarea for this purpose.
| #text-editor-preview { | ||
| max-height: 80vh; | ||
| overflow-y: scroll; | ||
| } | ||
| #text-editor-input { | ||
| resize: vertical; | ||
| } | ||
| .editor-wrapper-height { |
There was a problem hiding this comment.
I'd prefer working with a full-height parent element and paddings/margins instead. Do you think that could work?
There was a problem hiding this comment.
if the height is set 100% and the text is longer than the height of the textarea (scrollbar showing), the upper buttons div gets stagely cut by me, the only workaround I found was to subtract the height of the upper buttons, margins or paddings don't fix it
| @@ -338,6 +338,7 @@ export default defineComponent({ | |||
|
|
|||
| &__body { | |||
| overflow-y: auto; | |||
| overflow-x: hidden; | |||
There was a problem hiding this comment.
What does this prevent?
There was a problem hiding this comment.
@pascalwengerter In case the email is long, the horizontal scroll appears. Happens to all emails at CERN, I described in #6973
elizavetaRa
force-pushed
the
upstream_fixes
branch
from
a001acf
to
beba9b8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Description
Types of changes
Checklist:
Open tasks: