Fix webDavPath construction for space image and readme #7017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs to be a prefix match since the URL has the spaceId as nodeId in the URL (uniform 3-part id syntax) but the space id we maintain internally is 2-part.
AlexAndBear
approved these changes
May 20, 2022
kulmann
force-pushed
the
fix-space-cover-and-readme
branch
from
8629ebf
to
dda9a1d
Compare
|
Results for oC10XGAPortrait1 https://drone.owncloud.com/owncloud/web/25741/45/1 |
|
Kudos, SonarCloud Quality Gate passed! |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix webDavPath construction for space image and readme.
Finding the relative webDavPath needs to be a prefix match since the URL has the spaceId as nodeId in
the URL (uniform 3-part id syntax) but the space id we maintain
internally is 2-part.
I will not de-duplicate this code, because we want to use the absolute webDavUrl from the graph response ASAP anyway. And then all this splitting and finding goes away.
Types of changes
Checklist: