Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Do not cache files when opening them from public links #7075

Closed
wants to merge 3 commits into from

Conversation

diocas
Copy link
Contributor

@diocas diocas commented May 31, 2022

Set the newly added noCache option.

Waiting for a new tag of SDK.

@update-docs
Copy link

update-docs bot commented May 31, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pascalwengerter
Copy link
Contributor

Stopped CI and published a v3.0.0-alpha.11 in the SDK, which is available on NPM once https://drone.owncloud.com/owncloud/owncloud-sdk/3451 passes. Could you also bump the peerDependencies of the SDK and reference your PR in the "Bump SDK" changelog? :)

@diocas
Copy link
Contributor Author

diocas commented Jun 1, 2022

@pascalwengerter done, please check if is ok

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

changelog/unreleased/bugfix-nocache-pl Outdated Show resolved Hide resolved
@ownclouders
Copy link
Contributor

ownclouders commented Jun 1, 2022

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/26244/38/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-shareByPublicLink_feature-L133.png

webUISharingPublicManagement-shareByPublicLink_feature-L133.png

webUISharingPublicManagement-shareByPublicLink_feature-L162.png

webUISharingPublicManagement-shareByPublicLink_feature-L162.png

webUISharingPublicManagement-shareByPublicLink_feature-L49.png

webUISharingPublicManagement-shareByPublicLink_feature-L49.png

@pascalwengerter pascalwengerter changed the title Do not cache files when opening them from public links [full-ci] Do not cache files when opening them from public links Jun 2, 2022
@pascalwengerter
Copy link
Contributor

@diocas could I ask you to rebase&force-push to re-trigger CI? I've added the full-ci tag so we see which of the acceptance tests fail, then I can try to reproduce & debugg them locally:) could be the axios bump makes minor adjustments necessary, but let's see

@diocas
Copy link
Contributor Author

diocas commented Jun 2, 2022

The last time I believe the problem was with oc10, which did not accept the header. Let's see...

@diocas diocas force-pushed the up_nocache_pl branch 2 times, most recently from 6e56008 to 0b13fb2 Compare June 3, 2022 11:47
@kulmann
Copy link
Member

kulmann commented Jun 14, 2022

@dschmidt could you take a look here as well? Seems to be the same symptoms like a while ago with the noCache option for authenticated contexts with oc10 backend.

@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kulmann
Copy link
Member

kulmann commented Oct 12, 2022

@dschmidt could you port the changes to the current state of appDefaults composables (new PR is fine)?

@dschmidt
Copy link
Member

Superseded by #7811

@dschmidt dschmidt closed this Oct 17, 2022
@diocas diocas deleted the up_nocache_pl branch October 18, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants