Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide actions in space trash bins in case of insufficient permissions #7768

Merged
merged 5 commits into from
Oct 13, 2022
Merged

Hide actions in space trash bins in case of insufficient permissions #7768

merged 5 commits into from
Oct 13, 2022

Conversation

JammingBen
Copy link
Collaborator

Description

Actions in space trash bins are now hidden if the current user has insufficient permissions.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Oct 11, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Oct 11, 2022 •
edited

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/29049/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/29049/tracing/search-in-personal-spaces-alice-2022-10-12-08-39-37.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/29049/tracing/search-in-personal-spaces-brian-2022-10-12-08-39-27.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/29049/tracing/search-in-the-project-spaces-alice-2022-10-12-08-39-53.zip

💥 The e2e-ocis tests pipeline failed. The build has been cancelled.

@JammingBen JammingBen marked this pull request as ready for review October 12, 2022 09:27
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

58.3% 58.3% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🤩

@kulmann kulmann merged commit eea0f23 into master Oct 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-space-trashbin-actions branch October 13, 2022 12:06
@JammingBen JammingBen mentioned this pull request Oct 13, 2022
Merged
5 tasks
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Space viewer can see delete- and restore-actions in space trashbin
3 participants
@JammingBen @ownclouders @kulmann