Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Document titles #7791

Merged
merged 5 commits into from
Oct 13, 2022
Merged

[full-ci] Document titles #7791

merged 5 commits into from
Oct 13, 2022

Conversation

dschmidt
Copy link
Member

Description

Allow apps to set document titles and have them announced via the runtime.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Oct 13, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dschmidt dschmidt changed the title Document titles [full-ci] Document titles Oct 13, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

8.5% 8.5% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice 💪

@kulmann kulmann merged commit 8f4c38c into master Oct 13, 2022
@kulmann kulmann deleted the document-titles branch November 3, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page titles for spaces and trashes not dynamic [Drive alias followup]
3 participants
@dschmidt @kulmann @JammingBen