[full-ci] Drag & drop on Breadcrumb parent folder #9052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookacat
force-pushed
the
drag-drop-parent-folder
branch
from
b186d1f
to
47f3d49
Compare
lookacat
force-pushed
the
drag-drop-parent-folder
branch
from
47f3d49
to
a6c7e6d
Compare
lookacat
force-pushed
the
drag-drop-parent-folder
branch
2 times, most recently
from
86dbc77
to
b937913
Compare
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/36161/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36161/tracing/copy-and-move-resources-in-personal-space-alice-2023-5-30-09-55-03.zip |
kulmann
requested changes
May 26, 2023
packages/design-system/src/components/OcBreadcrumb/OcBreadcrumb.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/OcBreadcrumb/OcBreadcrumb.vue
Outdated
Show resolved
Hide resolved
lookacat
changed the title
kulmann
requested changes
May 30, 2023
packages/design-system/src/components/OcBreadcrumb/OcBreadcrumb.vue
Outdated
Show resolved
Hide resolved
kulmann
requested changes
May 31, 2023
|
SonarCloud Quality Gate failed. |
kulmann
requested changes
May 31, 2023
lookacat
force-pushed
the
drag-drop-parent-folder
branch
from
30606d2
to
f775e06
Compare
JammingBen
reviewed
May 31, 2023
packages/design-system/src/components/OcBreadcrumb/OcBreadcrumb.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/OcBreadcrumb/OcBreadcrumb.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/helpers/resource/actions/transfer.ts
Outdated
Show resolved
Hide resolved
JammingBen
approved these changes
May 31, 2023
lookacat
force-pushed
the
drag-drop-parent-folder
branch
from
f832cc4
to
50375f4
Compare
|
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
May 31, 2023
* WIP * WIP * Moving folders works * Refactor breadcrumb dropped method * Implement drop hover effect * Implement edge case error handling: same folder name * Remove dev leftover * Implement experimental styling * remove border, undo experimental breadcrumb styling * Make drop on root work * Add unittests for edge case * Fix rebase errors * Fix rebase issues * Fix disable drag/drop on current folder * Remove unused import / linting * Implement e2e tests * Rename dragover class * Add changelog * Address PR issues * Fix unittest * Fix e2e test for oc10 * Address PR issue * Set overflow visible * Fix buttons having different font feature settings * Address PR issue * Refactor AppBar drop logic into GenericSpace * Remove unused import * Address PR issues * remove unused resize event listener * Make linter happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!Please review first (as this PR is based on that):#8984
Description
See #9043
Related Issue
Types of changes
Checklist:
Open tasks: