[full-ci] Table view for project spaces overview #9195
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
WIP what? Can you provide a better title please? 😇 |
|
@dschmidt sorry added it, had to quickly push and used WIP as title :D |
lookacat
changed the title
|
Results for e2e-tests oCIS-2 https://drone.owncloud.com/owncloud/web/36727/13/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36727/tracing/unstructured-collection-of-testable-space-interactions-alice-2023-6-21-08-32-34.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36727/tracing/unstructured-collection-of-testable-space-interactions-alice-2023-6-21-08-33-13.zip |
|
arg, sorting for some fields doesnt work yet as well as reducing the table for smaller screens |
packages/web-app-files/src/components/FilesList/ResourceTable.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/FilesList/ResourceTable.vue
Outdated
Show resolved
Hide resolved
lookacat
force-pushed
the
space-overview-table
branch
from
1917f22
to
2b9b1b6
Compare
lookacat
changed the title
lookacat
force-pushed
the
space-overview-table
branch
from
3cadf03
to
7048577
Compare
|
Results for e2e-tests oCIS-1 https://drone.owncloud.com/owncloud/web/36651/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36651/tracing/create-space-from-folder-alice-2023-6-19-01-15-19.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36651/tracing/create-space-from-resources-alice-2023-6-19-01-15-32.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36651/tracing/search-in-the-project-spaces-alice-2023-6-19-01-20-14.zip |
lookacat
force-pushed
the
space-overview-table
branch
2 times, most recently
from
8fcbb24
to
7b0c968
Compare
lookacat
force-pushed
the
space-overview-table
branch
from
abb0493
to
39e2328
Compare
|
Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/36685/67/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicManagement-sharingPublicSession_feature-L52.png |
|
Im still fixing viewport sizes... |
| </template> | ||
| <template #remainingQuota="{ item }"> | ||
| <slot name="remainingQuota" :resource="item" /> | ||
| </template> |
There was a problem hiding this comment.
Hmmm does it really make sense to add all these columns to the generic resource table?
Wouldn't it make more sense to add these dynamically from the parent component where needed?
There was a problem hiding this comment.
but we need them as fields, or what do you mean by dynamically from the parent?
There was a problem hiding this comment.
Nice, LGTM for the most parts. A few small annotations from my side.
- Could you switch positions of the tiles- and the table-viewmode buttons to keep consistency with the regular files table? The tiles view button should be in the right side.
- I think the quota columns need to be hidden sooner on smaller screen sizes. See:
packages/web-app-files/src/components/FilesList/ResourceTable.vue
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
Description
See #9204
Screenshots
Related Issue
Types of changes
Checklist: