Add status badge template option to OcResourceIcon #9568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
lookacat
changed the title
lookacat
commented
Aug 12, 2023
| @@ -229,6 +242,32 @@ export default defineComponent({ | |||
| max-height: $oc-size-icon-default * 1.5; | |||
| width: $oc-size-icon-default * 1.5; | |||
| max-width: $oc-size-icon-default * 1.5; | |||
|
|
|||
| &-status-badge { | |||
There was a problem hiding this comment.
this is because we need a different status badge for preview items (since its not an normal file icon)
lookacat
commented
Aug 12, 2023
packages/design-system/src/components/OcResource/OcResource.vue
Outdated
Show resolved
Hide resolved
lookacat
commented
Aug 12, 2023
| @@ -51,6 +51,7 @@ export interface Resource { | |||
| thumbnail?: string | |||
| status?: number | |||
| processing?: boolean | |||
| locked?: boolean | |||
There was a problem hiding this comment.
not needed in this PR but i use this property to set the locked status of a file
lookacat
commented
Aug 12, 2023
packages/design-system/src/components/OcResourceIcon/OcResourceIcon.vue
Outdated
Show resolved
Hide resolved
JammingBen
reviewed
Aug 15, 2023
packages/design-system/src/components/OcResource/OcResource.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/OcResourceIcon/OcResourceIcon.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/OcResource/OcResource.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/OcResourceIcon/OcResourceIcon.vue
Outdated
Show resolved
Hide resolved
JammingBen
approved these changes
Aug 16, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
AlexAndBear
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Add status badge to OcResourceIcon * Refactor code / add template option / add spinner alignment & color * Cleanup code * Fix thumbnail badge * Implement condensed badge view * Remove dev leftover * fix bug * fix bug * Fix bug * Implement for tiles view * Update snapshots * Move styles out of OcResourceIcon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've added the option to set an additional status badge to be displayed on the lower right on the OcResourceIcon (e.g. for locking information or loading spinner)
Related Issue
Screenshots (if appropriate):
Example with icon
Dark mode:
Light mode:
Example with loading spinner:
Tiles view:
Condensed table:
Types of changes
Checklist: