Implement filter for Project Spaces #9649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
lookacat
force-pushed
the
feat-filter-project-spaces
branch
from
b89b1c4
to
5031123
Compare
lookacat
commented
Sep 5, 2023
| @@ -75,6 +82,8 @@ describe('Projects view', () => { | |||
| }) | |||
|
|
|||
| function getMountedWrapper({ mocks = {}, spaces = [], abilities = [], stubAppBar = true } = {}) { | |||
| jest.mocked(queryItemAsString).mockImplementationOnce(() => '1') | |||
There was a problem hiding this comment.
is needed for pagination
lookacat
requested review from
dschmidt,
AlexAndBear,
JammingBen and
grimmoc
JammingBen
requested changes
Sep 5, 2023
|
Kudos, SonarCloud Quality Gate passed! |
12 tasks
AlexAndBear
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Implement filter for Project Spaces * Fix search not working * Make highlighting work * Add changelog * Add pagination * Fix snapshot * Fix unittests * Add unittest for filter * Fix faulty naming * Add pagination for tiles * Increase margin * Update snapshots * Remove unussed ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've added the option to search for spaces in the project space overview.
See #9650
Related Issue
Screenshots (if appropriate):
Types of changes
Checklist: