Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: space image upload #9844

Merged
merged 3 commits into from Oct 24, 2023
Merged

fix: space image upload #9844

merged 3 commits into from Oct 24, 2023

Conversation

fschade
Copy link
Collaborator

@fschade fschade commented Oct 23, 2023 •
edited

Description

Space image upload failed due to some code changes, this fixed and works as expected again.

Related Issue

How Has This Been Tested?

  • e2e

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@fschade fschade added Type:Bug Something isn't working Status:Needs-Review Needs review from a maintainer labels Oct 23, 2023
@fschade fschade self-assigned this Oct 23, 2023
JammingBen
JammingBen approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care 🚀

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

73.3% 73.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@fschade fschade merged commit 628a182 into master Oct 24, 2023
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-space-image branch October 24, 2023 08:18
LukasHirt pushed a commit to LukasHirt/web that referenced this pull request Oct 25, 2023
@fschade @LukasHirt
fix: space image upload (owncloud#9844)
acf24cf 
* fix: space image upload
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@fschade @AlexAndBear
fix: space image upload (#9844)
f0b32dc 
* fix: space image upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt left review comments

@JammingBen JammingBen JammingBen approved these changes

Assignees

@fschade fschade

Labels
Status:Needs-Review Needs review from a maintainer Type:Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Space image upload is broken
3 participants
@fschade @dschmidt @JammingBen