Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big font size in the contact's info #1153

Closed
Allineer opened this issue Dec 19, 2021 · 17 comments
Closed

Big font size in the contact's info #1153

Allineer opened this issue Dec 19, 2021 · 17 comments

Comments

@Allineer
Copy link
Contributor

24600 OSS

Big font size in the contact's info.
It is ok?

IMG_20211219_185001_938

@jpmens
Copy link
Member

jpmens commented Dec 19, 2021

Are you saying you find the font size is too large?

@growse
Copy link
Collaborator

growse commented Dec 19, 2021

I suspect what's happened here is that since I fiddled with the layout to tell the content to auto-reduce its size to fit if its too large, it's now auto-increasing the size to fit if its too small.

I'm not convinced this is an issue, but will happily take advice on what a maximum size value should be.

@Allineer
Copy link
Contributor Author

I think the font size is pointlessly large.

I would suggest using the size as in the rest of the application.

By example:
Screenshot_2021-12-19-19-21-45-490_org owntracks android

PS distance and direction (azimuth) to contact is no longer available?

@growse
Copy link
Collaborator

growse commented Dec 19, 2021

I guess that's a fair point. Will see if I can set a maximum on the auto sizing,

You don't get a distance / direction to a contact if either there is no local location fix or if the contact has no location available (hasn't published since we started up and connected for the first time).

@kri164
Copy link

kri164 commented Dec 20, 2021

Just FYI, how it looks in another laguage.

Screenshot_20211220-180002_OwnTracks

@kri164
Copy link

kri164 commented Dec 20, 2021

Why there are icons on upper right corner on some phones, while there is 3-dot (hamburger) menu on others?

@Allineer
Copy link
Contributor Author

Allineer commented Dec 20, 2021

how it looks in another laguage.

In Russian with Vzdalenost and Smer it looks very similar :)

PS I don't see any burgers here...

@Allineer
Copy link
Contributor Author

@growse how about decreasing the distance between the blocks instead of changing the font size?

@growse
Copy link
Collaborator

growse commented Dec 21, 2021

Why there are icons on upper right corner on some phones, while there is 3-dot (hamburger) menu on others?

Screen resolution. Android hides / shows actionbar menu items depending on the amount of horizontal space available.

@growse how about decreasing the distance between the blocks instead of changing the font size?

I'm going to stick with limiting the font size for the moment, and then see if we need to do anything else.

@Allineer
Copy link
Contributor Author

Allineer commented Aug 22, 2022

image

@growse how about to show this labels with a some same font size?

@growse
Copy link
Collaborator

growse commented Aug 23, 2022

(do you mean "same"?)

The labels are currently autosizing to fit, up to a max. Do you think that all the labels should be sized the same so that the longest one fits?

@Allineer
Copy link
Contributor Author

(do you mean "same"?)

yup :)

Do you think that all the labels should be sized the same so that the longest one fits?

Right.
I think different font sizes looks terrible. Perhaps if you make them equally small, like the "Distance" label in the screenshot, it should turn out more pretty.
Can you try this?

@growse
Copy link
Collaborator

growse commented Aug 23, 2022

I'll see if there's a way of hooking into the text drawing mechanism post-sizing calculations, so that I can set all the sizes to be the same. This'll be a different value depending on lang and display (orientation/dpi etc.) so would have to be worked out on the fly.

@growse
Copy link
Collaborator

growse commented Aug 25, 2022

What think?

(I should probably do something about that awful floating point latlng issue too...)

image
image

@Allineer
Copy link
Contributor Author

@growse I like it!

@jpmens
Copy link
Member

jpmens commented Aug 26, 2022

@growse I agree on both accounts: the fonts look much neater now, and the lat,lon looks meh. :-)

@growse
Copy link
Collaborator

growse commented Aug 26, 2022

I'll create a PR for the 2.4.11 release, and a separate issue about truncating latlngs to a sensible number of dps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants