Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust contactsheet labels to be the same size as each other #1277

Merged
merged 6 commits into from
Nov 2, 2022

Conversation

growse
Copy link
Collaborator

@growse growse commented Aug 26, 2022

The labels on the contactsheet previously auto-sized themselves to fit, but it was suggested in #1153 that it would look better if they were all the same size. So a little adjustment where the labels use an implementation of TextView that broadcasts the textsize after its onDraw call. Anything else that's listening to that can then adjust its size accordingly. Grouped together, all the 6 contact labels should then all be the same size.

@growse growse added this to the 2.4.11 milestone Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Base: 46.36% // Head: 40.94% // Decreases project coverage by -5.42% ⚠️

Coverage data is based on head (ebb4a36) compared to base (7f826be).
Patch coverage: 28.16% of modified lines in pull request are covered.

❗ Current head ebb4a36 differs from pull request most recent head 164a964. Consider uploading reports for the commit 164a964 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1277      +/-   ##
============================================
- Coverage     46.36%   40.94%   -5.43%     
+ Complexity     1017      882     -135     
============================================
  Files           172      173       +1     
  Lines          6731     6785      +54     
  Branches        687      693       +6     
============================================
- Hits           3121     2778     -343     
- Misses         3221     3641     +420     
+ Partials        389      366      -23     
Flag Coverage Δ
uitests 40.94% <28.16%> (-0.47%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/org/owntracks/android/ui/map/MapActivity.kt 5.61% <24.39%> (+1.70%) ⬆️
...org/owntracks/android/ui/map/osm/OSMMapFragment.kt 75.94% <25.00%> (-0.45%) ⬇️
...android/ui/map/AutoResizingTextViewWithListener.kt 34.61% <34.61%> (ø)
.../java/org/owntracks/android/model/CommandAction.kt 0.00% <0.00%> (-100.00%) ⬇️
...rg/owntracks/android/model/messages/MessageCard.kt 0.00% <0.00%> (-100.00%) ⬇️
...ntracks/android/model/messages/MessageEncrypted.kt 0.00% <0.00%> (-100.00%) ⬇️
...org/owntracks/android/model/messages/MessageCmd.kt 0.00% <0.00%> (-62.50%) ⬇️
...g/owntracks/android/model/messages/MessageClear.kt 0.00% <0.00%> (-60.00%) ⬇️
...tracks/android/model/messages/MessageTransition.kt 0.00% <0.00%> (-60.00%) ⬇️
...rg/owntracks/android/geocoding/OpenCageGeocoder.kt 10.52% <0.00%> (-58.95%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@growse growse force-pushed the master branch 6 times, most recently from 442f735 to da44962 Compare September 18, 2022 13:01
@growse growse force-pushed the master branch 4 times, most recently from 1462038 to 6d76f1b Compare October 2, 2022 15:31
@growse growse force-pushed the contactsheet-labels-the-same-size branch from 163219e to 6a07729 Compare October 2, 2022 15:42
@growse growse marked this pull request as ready for review October 2, 2022 15:49
@growse growse added the integration-test-required PRs that need a full integration test suite before merging label Oct 2, 2022
@growse growse force-pushed the contactsheet-labels-the-same-size branch 2 times, most recently from fb34ae0 to ebb4a36 Compare November 2, 2022 10:28
@growse growse added integration-test-required PRs that need a full integration test suite before merging and removed integration-test-required PRs that need a full integration test suite before merging labels Nov 2, 2022
@growse growse force-pushed the contactsheet-labels-the-same-size branch from ebb4a36 to c7ad2b4 Compare November 2, 2022 10:59
@growse growse merged commit 95898cf into master Nov 2, 2022
@growse growse deleted the contactsheet-labels-the-same-size branch November 2, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-test-required PRs that need a full integration test suite before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant