-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Squeeze operator #124
Conversation
6e0d5e2
to
427b566
Compare
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 85.38% 85.42% +0.03%
==========================================
Files 392 393 +1
Lines 10279 10334 +55
==========================================
+ Hits 8777 8828 +51
- Misses 1316 1318 +2
- Partials 186 188 +2
Continue to review full report at Codecov.
|
Hello, Thanks for this PR; Therefore, your implementation should have been tested by the CI already (and the CI is green so I assume the code is ok) You can try it manually by running I will review the code and merge the PR; thanks again. |
The tests of the init functions are usually not covered. We may need to add something to test them easily. WDYT? |
Sure, I'll take care of that. |
I mean: |
427b566
to
b1c822f
Compare
Done - I added unit tests for the various attributes which could be found in an ONNX. |
Hi,
I've added the Squeeze operator, following a previous PR on Unsqueeze.
Specifications are here: https://github.com/onnx/onnx/blob/master/docs/Operators.md#squeeze
I'll try to add more tests, but do you have any tips to generate the model and put it in binary in the test?
Thanks!