Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Squeeze operator #124

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Conversation

bezineb5
Copy link
Contributor

@bezineb5 bezineb5 commented Sep 11, 2019

Hi,

I've added the Squeeze operator, following a previous PR on Unsqueeze.
Specifications are here: https://github.com/onnx/onnx/blob/master/docs/Operators.md#squeeze

I'll try to add more tests, but do you have any tips to generate the model and put it in binary in the test?

Thanks!

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #124 into master will increase coverage by 0.03%.
The diff coverage is 92.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   85.38%   85.42%   +0.03%     
==========================================
  Files         392      393       +1     
  Lines       10279    10334      +55     
==========================================
+ Hits         8777     8828      +51     
- Misses       1316     1318       +2     
- Partials      186      188       +2
Impacted Files Coverage Δ
backend/x/gorgonnx/squeeze.go 92.72% <92.72%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611bf02...b1c822f. Read the comment docs.

@owulveryck
Copy link
Contributor

Hello,

Thanks for this PR;
Some tests are auto generated by the testbackend package in gorgonnx.
All the operators are tested and those triggering an ErrNotImplemented ate skipped.

Therefore, your implementation should have been tested by the CI already (and the CI is green so I assume the code is ok)

You can try it manually by running go test -run=ONNX/Unsqueeze -v within gorgonnx.

I will review the code and merge the PR; thanks again.

@owulveryck
Copy link
Contributor

The tests of the init functions are usually not covered. We may need to add something to test them easily. WDYT?

@bezineb5
Copy link
Contributor Author

Sure, I'll take care of that.

@owulveryck
Copy link
Contributor

You can try it manually by running go test -run=ONNX/Unsqueeze -v within gorgonnx.

I mean: go test -run=ONNX/Squeeze -v

@bezineb5
Copy link
Contributor Author

Done - I added unit tests for the various attributes which could be found in an ONNX.

@owulveryck owulveryck merged commit 3470077 into askorama:master Sep 12, 2019
@bezineb5 bezineb5 deleted the squeeze-operator branch September 12, 2019 11:42
owulveryck pushed a commit that referenced this pull request Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants