Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC App name on Munkitools 5.2 #45

Closed
jstaubr opened this issue Nov 25, 2020 · 6 comments
Closed

MSC App name on Munkitools 5.2 #45

jstaubr opened this issue Nov 25, 2020 · 6 comments

Comments

@jstaubr
Copy link

jstaubr commented Nov 25, 2020

Hello,

the recently released munkitools 5.2 have probably made some changes that prevent renaming the Managed Software Center.app and the app name remains original. Inside the app strings are correctly replaced:
Screenshot 2020-11-25 at 11 27 24

Give me a shout If I can provide other info or debug...

@fuzzylogiq
Copy link
Collaborator

Hi yup I'm aware of the issue and I'm in the process of producing a PR for the main munki code (munki_rebrand is working as intended)

@Welshdwarf
Copy link

Hello, is it possible to call an old version of MSC in the script ?
The MUNKIURL
Thanks.

@jstaubr
Copy link
Author

jstaubr commented Nov 25, 2020

Hi yup I'm aware of the issue and I'm in the process of producing a PR for the main munki code (munki_rebrand is working as intended)

Thanks!

@SilentHunter124
Copy link

Is there a manual workaround we can do if we build munki on our own?

@fuzzylogiq
Copy link
Collaborator

Is there a manual workaround we can do if we build munki on our own?

Yes you could build it from my fork (i'll keep it around for now) https://github.com/fuzzylogiq/munki (clone to your computer then run code/tools/make_munki_mpkg.sh) then pass that to munki_rebrand.py with the -k option

@jstaubr
Copy link
Author

jstaubr commented Dec 17, 2020

Hi everyone,
Latest 5.2.1 release fixes the issue for me.
https://github.com/munki/munki/releases/tag/v5.2.1

@jstaubr jstaubr closed this as completed Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants