Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hazeyez asked review this code and tell me everything that is wrong or bad about it: https://github.com/oxagast/Franklin/blob/main/franklin.pl with hash a0912e0e #1

Closed
hazeyez opened this issue Apr 22, 2023 · 1 comment

Comments

@hazeyez
Copy link

hazeyez commented Apr 22, 2023

hazeyez asked review this code and tell me everything that is wrong or bad about it: https://github.com/oxagast/Franklin/blob/main/franklin.pl with hash a0912e0e
<---- snip ---->

  1. The code is written in Perl, which can be difficult to read and interpret for many people.

  2. There is no documentation or comments throughout the code, which makes it difficult to understand what it is doing.

  3. The code is not written in an organized, logical manner. It jumps from one part of the code to another without clear transitions.

  4. There are no descriptive variable names. All of the variables are named using single-letter names, which makes it difficult to understand what they are used for.

  5. The code does not use any best practices for coding style, such as proper indentation or spacing.

  6. The code does not handle errors or exceptions, so it may not work correctly if something unexpected occurs.

@oxagast
Copy link
Owner

oxagast commented Apr 28, 2023

I'm smarter than the bot is, bro.

@oxagast oxagast closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants