Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(semantic): node -> symbol lookup #225

Closed
Boshen opened this issue Mar 29, 2023 · 1 comment
Closed

feat(semantic): node -> symbol lookup #225

Boshen opened this issue Mar 29, 2023 · 1 comment
Labels
A-linter Area - Linter A-minifier Area - Minifier A-semantic Area - Semantic C-question Category - A question rather than an issue E-Help Wanted Experience level - For the experienced collaborators

Comments

@Boshen
Copy link
Member

Boshen commented Mar 29, 2023 •
edited
Loading

Currently there's no method for look up a symbol from a BindingIdentifier / IdentifierReference inside the linter.

The minifier also need this for the printer to print mangled names.

One possible solution is to create an index for a Span -> SymbolId lookup.

I wonder we should make an overhaul on the Symbol Table. I had no idea what I was doing when I wrote the symbol table, and I wrote whatever is sensible.
@Boshen Boshen added E-Help Wanted Experience level - For the experienced collaborators C-question Category - A question rather than an issue A-linter Area - Linter A-semantic Area - Semantic A-minifier Area - Minifier labels Mar 29, 2023
@Boshen Boshen added this to the 0.0.3 milestone Mar 29, 2023
@Boshen Boshen mentioned this issue Mar 31, 2023
Closed
54 tasks
@Boshen Boshen removed this from the 0.0.3 milestone Apr 2, 2023
@YangchenYe323 YangchenYe323 mentioned this issue Apr 2, 2023
Closed
@YangchenYe323
Copy link
Contributor

When working on #247 I found that the extra hashing steps make the semantic builder 10x slower. Is it an option to remove the hashing altogether and store an additional SymbolIdwith BindingIdentifier and ReferenceId with IdentifierReference?

@YangchenYe323 YangchenYe323 mentioned this issue Apr 2, 2023
Merged
@Boshen Boshen closed this as completed Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linter Area - Linter A-minifier Area - Minifier A-semantic Area - Semantic C-question Category - A question rather than an issue E-Help Wanted Experience level - For the experienced collaborators
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Boshen @YangchenYe323