parser: exported functions do not have ModifierKind::Export flag

[DonIsaac]

Within the AST, exported functions do not contain an exported flag.

Example

this code

export function foo() { }

turns into this AST:

{
  "type": "Program",
  "start": 0,
  "end": 24,
  "sourceType": {
    "language": {
      "typeScript": {
        "isDefinitionFile": false
      }
    },
    "moduleKind": "module",
    "variant": "jsx",
    "alwaysStrict": false
  },
  "directives": [],
  "hashbang": null,
  "body": [
    {
      "type": "ExportNamedDeclaration",
      "start": 0,
      "end": 24,
      "declaration": {
        "type": "FunctionDeclaration",
        "start": 7,
        "end": 24,
        "id": {
          "type": "BindingIdentifier",
          "start": 16,
          "end": 19,
          "name": "foo"
        },
        "expression": false,
        "generator": false,
        "async": false,
        "params": {
          "type": "FormalParameters",
          "start": 19,
          "end": 21,
          "kind": "FormalParameter",
          "items": [],
          "rest": null
        },
        "body": {
          "type": "FunctionBody",
          "start": 22,
          "end": 24,
          "directives": [],
          "statements": []
        },
        "typeParameters": null,
        "returnType": null,
        "modifiers": []
      },
      "specifiers": [],
      "source": null,
      "export_kind": {
        "type": "value"
      }
    }
  ]
}

Notice how modifiers is empty.

[Boshen]

What's your use case?

The modifiers are meant to store erroneous (extra) modifiers. They were added to fix some error messages in TypeScript.

Also, the export is not really a modifier, but the start of the export declaration ExportNamedDeclaration. Y

[DonIsaac]

Ah, I was expecting this to be usage flags. I was checking it to see if a const/function was getting exported for no-unused-vars

[Boshen]

@DonIsaac Take a look at Export in SymbolFlags. crates/oxc_syntax/src/symbol.rs